Size Change: 0 B

Total Size: 1.82 MB

_{compressed-size-action}

It will trigger an ESLint error everywhere where we ignore a react/* ESLint rule:

React Compiler has skipped optimizing this component because one or more React ESLint rules were disabled. React Compiler only works when your components follow all the rules of React, disabling them may result in unexpected or incorrect behavior

Seems like it will try hard to let us follow all the rules, which can create quite some additional work 😐

I kinda like the new stricter rules, but I agree it would take some time to bring the codebase into shape.

P.S. I'll push fixes for some low-hanging errors separately.

I kinda like the new stricter rules, but I agree it would take some time to bring the codebase into shape.

P.S. I'll push fixes for some low-hanging errors separately.

I'd love to help with those too. Please ping me for reviews!

@tyxla, should we start a list of false positive errors that linter generates and then report those upstream?

Example

• Updating ref value on event callbacks. Setting the ref value during the render isn't recommended, but it should be okay in event handlers. File - packages/block-editor/src/components/inserter-list-item/index.js.

@tyxla, should we start a list of false positive errors that linter generates and then report those upstream?

Example

• Updating ref value on event callbacks. Setting the ref value during the render isn't recommended, but it should be okay in event handlers. File - packages/block-editor/src/components/inserter-list-item/index.js.

Yep, definitely. The top-level await could also be one to report (currently not occurring because I've ignored the files where it happens).

Flaky tests detected in 3bfdcd2.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11907672938
📝 Reported issues:

• [Flaky Test] submenu click on the arrow interactions #61884 in /test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js

I noticed that new lint rules do not like the hook pattern used by the command API:

Example:

useCommandLoader( {
  name: 'core/edit-site/reset-global-styles',
  hook: useGlobalStylesResetCommands,
} );

I noticed that new lint rules do not like the hook pattern used by the command API:

The solution to that will most likely be just renaming them to not follow the hook naming convention. After all, they are technically not hooks since they're violating the rules of hooks and React can't recognize them as hooks through static code analysis:

It looks like, after the latest update, the plugin complains about setting the ref value inside effects.

It looks like, after the latest update, the plugin complains about setting the ref value inside effects.

Yes, looks like it's a known bug: facebook/react#29196

I'm talking about different case that's is supported in React and ref is coming from local useRef hook. Example: https://github.com/WordPress/gutenberg/actions/runs/9305858965/job/25613775078?pr=61788#step:5:53.

I'm not able to reproduce it on React Compiler Playground though.

Screenshot

Perhaps I'm misunderstanding, but isn't that precisely the bug reported in the issue I linked above?

Thanks for working on those fixes @Mamaduka 🚀 🙇

Unless something sneaks in, this should be the last fix before we enable the ESLint plugin: #67085

@tyxla, what do you think about merging the new link rules? Are there any possible downsides?

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka, this one is ready for review - please take a look when you have a chance.

@tyxla, what do you think about merging the new link rules? Are there any possible downsides?

Sorry @Mamaduka, which ones do you mean? In any case, I'd like to land this one first, and then we can tinker with any customizations in subsequent PRs.

In the meantime, in 3bfdcd2 I've moved the ESLint config to the project level instead of the package since having a beta plugin in the package is debatable and could create some maintenance issues.

Thank you @Mamaduka and @gziolo 🙌

I don't have enough insights on wether version 19.0.0-beta-8a03594-20241020 is stable enough. The code changes itself look great. Excellent work on enabling all these rules inside Gutenberg repository.

There's a newer beta, and there's one every few days. I'm planning to keep the plugin up to date in subsequent PRs, but I want to enable it so folks stop introducing violations.

There is also this challenge that the ESLint plugin targets React 19. It doesn't seem to be a problem here, but you never know with wider set of projects.

Yes, once React 19 actually gets released, this will be a bigger issue to consider.

Bumping to the latest version here: #67106